vanzin commented on a change in pull request #26869: [SPARK-30235][CORE]
Switching off host local disk reading of shuffle blocks in case of
useOldFetchProtocol
URL: https://github.com/apache/spark/pull/26869#discussion_r358429592
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -478,7 +478,8 @@ private[spark] class BlockManager(
}
hostLocalDirManager =
- if (conf.get(config.SHUFFLE_HOST_LOCAL_DISK_READING_ENABLED)) {
+ if (conf.get(config.SHUFFLE_HOST_LOCAL_DISK_READING_ENABLED) &&
+ !conf.get(config.SHUFFLE_USE_OLD_FETCH_PROTOCOL)) {
Review comment:
indent more
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
