dongjoon-hyun commented on a change in pull request #26904: [SPARK-30265][INFRA] Do not change R version when releasing preview versions URL: https://github.com/apache/spark/pull/26904#discussion_r358432617
########## File path: dev/create-release/release-tag.sh ########## @@ -73,8 +73,12 @@ git config user.email $GIT_EMAIL # Create release version $MVN versions:set -DnewVersion=$RELEASE_VERSION | grep -v "no value" # silence logs -# Set the release version in R/pkg/DESCRIPTION -sed -i".tmp1" 's/Version.*$/Version: '"$RELEASE_VERSION"'/g' R/pkg/DESCRIPTION +if [[ $RELEASE_VERSION != *"preview"* ]]; then + # Set the release version in R/pkg/DESCRIPTION + sed -i".tmp1" 's/Version.*$/Version: '"$RELEASE_VERSION"'/g' R/pkg/DESCRIPTION +else + sed -i".tmp1" 's/-SNAPSHOT/'"-$(cut -d "-" -f 2 <<< $RELEASE_VERSION)"'/g' R/pkg/R/sparkR.R Review comment: This sounds like a side-effect of skipping the release commit. ( https://github.com/apache/spark/pull/26879 ) Thank you for keeping working in this direction. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
