yaooqinn commented on a change in pull request #26905: [SPARK-30266][SQL] Avoid
overflow and match error in ApproximatePercentile
URL: https://github.com/apache/spark/pull/26905#discussion_r358568323
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/ApproximatePercentileQuerySuite.scala
##########
@@ -182,7 +182,7 @@ class ApproximatePercentileQuerySuite extends QueryTest
with SharedSparkSession
spark.sql(
s"""SELECT
| key,
- | percentile_approx(null, 0.5)
+ | percentile_approx(cast(null as int), 0.5)
Review comment:
I have checked hive, `percentile_approx(null, 0.5)` is not valid. If it
worth to keep back-compatibility of this, I can make NullType acceptable for
percentile_approx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
