Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4524#discussion_r24531964
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
 ---
    @@ -128,6 +128,29 @@ abstract class LogicalPlan extends 
QueryPlan[LogicalPlan] with Logging {
       def resolve(name: String, resolver: Resolver): Option[NamedExpression] =
         resolve(name, output, resolver)
     
    +  def resolveAsTableColumn(
    --- End diff --
    
    If we are going to merge this, can you add javadoc for these two methods to 
explain what they do, and what the differences are?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to