Github user nchammas commented on the pull request:

    https://github.com/apache/spark/pull/4540#issuecomment-73991052
  
    @dyross Thank you for fixing this issue. Could you:
    * Create a sub-task under 
[SPARK-5747](https://issues.apache.org/jira/browse/SPARK-5747) for 
`make-distribution.sh`
    * Update the title of this PR to reference the new JIRA issue
    * Resolve all other word splitting issues with `make-distribution.sh`
    
    Totally fine if you just want to fix the call to Maven, but there are a few 
other problematic places in this script.
    
    For example:
    * [sub-shell output may contain 
spaces](https://github.com/apache/spark/blob/fa6bdc6e819f9338248b952ec578bcd791ddbf6d/make-distribution.sh#L101)
    * [`$RPM_JAVA_HOME` may contain 
spaces](https://github.com/apache/spark/blob/fa6bdc6e819f9338248b952ec578bcd791ddbf6d/make-distribution.sh#L103)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to