yaooqinn commented on a change in pull request #26905: [SPARK-30266][SQL] Avoid
match error and int overflow in ApproximatePercentile
URL: https://github.com/apache/spark/pull/26905#discussion_r360297425
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentileSuite.scala
##########
@@ -300,12 +308,50 @@ class ApproximatePercentileSuite extends SparkFunSuite {
assert(agg.child.dataType == IntegerType)
assert(agg.percentageExpression.dataType == DoubleType ||
agg.percentageExpression.dataType == ArrayType(DoubleType,
containsNull = false))
- assert(agg.accuracyExpression.dataType == IntegerType)
+ assert(agg.accuracyExpression.dataType.isInstanceOf[IntegralType])
case _ => fail()
}
}
}
}
+ test("ApproximatePercentile: nulls in percentage expression") {
+
+ assert(new ApproximatePercentile(
+ AttributeReference("a", DoubleType)(),
+ percentageExpression = Literal(null, DoubleType)).checkInputDataTypes()
===
+ TypeCheckFailure("Percentage value must not be null"))
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
