cloud-fan commented on a change in pull request #26968:
[SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#discussion_r360801607
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -205,6 +205,7 @@ case class AdaptiveSparkPlanExec(
// Run the final plan when there's no more unfinished stages.
currentPhysicalPlan = applyPhysicalRules(result.newPlan,
queryStageOptimizerRules)
+ executionId.foreach(onUpdatePlan)
Review comment:
ah good catch! somehow I misread the code and thought it doesn't matter.
For UI it doesn't matter as we will strip the `AdaptiveSparkPlanExec`, but
if there is a spark listener catching this event, it matters.
Can you send a PR to fix it? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
