cloud-fan commented on a change in pull request #26809: [SPARK-30185][SQL]
Implement Dataset.tail API
URL: https://github.com/apache/spark/pull/26809#discussion_r360819691
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/LocalTableScanExec.scala
##########
@@ -77,6 +77,16 @@ case class LocalTableScanExec(
taken
}
+ override def executeTail(limit: Int): Array[InternalRow] = {
+ var taken: Seq[InternalRow] = Seq.empty[InternalRow]
Review comment:
shall we simply call `takeRight`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
