Github user yanbohappy commented on a diff in the pull request:
https://github.com/apache/spark/pull/4527#discussion_r24574169
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/json/JsonRDD.scala
---
@@ -39,7 +39,19 @@ private[sql] object JsonRDD extends Logging {
json: RDD[String],
schema: StructType,
columnNameOfCorruptRecords: String): RDD[Row] = {
- parseJson(json, columnNameOfCorruptRecords).map(parsed =>
asRow(parsed, schema))
+ // Reuse the mutable row for each record, however we still need to
+ // create a new row for every nested struct type in each record
+ val mutableRow = new SpecificMutableRow(schema.fields.map(_.dataType))
--- End diff --
You are right, it's not appropriate to use SpecificMutableRow here. I will
change back to GenericMutableRow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
