Ngone51 commented on a change in pull request #26980: [SPARK-27348][Core]
HeartbeatReceiver should remove lost executors from
CoarseGrainedSchedulerBackend
URL: https://github.com/apache/spark/pull/26980#discussion_r361243811
##########
File path: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala
##########
@@ -153,7 +154,6 @@ class HeartbeatReceiverSuite
heartbeatReceiverClock.advance(executorTimeout)
heartbeatReceiverRef.askSync[Boolean](ExpireDeadHosts)
// Only the second executor should be expired as a dead host
- verify(scheduler).executorLost(meq(executorId2), any())
Review comment:
Remove this because we no longer invoke `scheduler.executorLost` in
`HeartbeatReceiver`'s main thread. And asserts below have already proved that
`executorId2` has been expired. So, I think it should be fine to remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
