cloud-fan commented on a change in pull request #26975: [SPARK-30325][CORE]
markPartitionCompleted cause task status inconsistent
URL: https://github.com/apache/spark/pull/26975#discussion_r361314146
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -939,7 +939,7 @@ private[spark] class TaskSetManager(
&& !isZombie) {
for ((tid, info) <- taskInfos if info.executorId == execId) {
val index = taskInfos(tid).index
- if (successful(index) && !killedByOtherAttempt.contains(tid)) {
+ if (successful(index) && !info.running &&
!killedByOtherAttempt.contains(tid)) {
Review comment:
let's add some code comments here to explain what's going on. e.g. we may
have a running task whose partition has been marked as successful, because this
partition has another task in another stage attempt.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
