maropu commented on a change in pull request #27005: [SPARK-30350][SQL] Fix
ScalaReflection to use an empty array for getting its class object
URL: https://github.com/apache/spark/pull/27005#discussion_r361345326
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -127,7 +127,7 @@ object ScalaReflection extends ScalaReflection {
case other =>
// There is probably a better way to do this, but I couldn't find it...
val elementType = dataTypeFor(other).asInstanceOf[ObjectType].cls
- java.lang.reflect.Array.newInstance(elementType, 1).getClass
+ java.lang.reflect.Array.newInstance(elementType, 0).getClass
Review comment:
cc: @srowen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
