Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/2504#discussion_r24613511
--- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala ---
@@ -54,14 +55,13 @@ case class Aggregator[K, V, C] (
}
combiners.iterator
} else {
- val combiners = new ExternalAppendOnlyMap[K, V, C](createCombiner,
mergeValue, mergeCombiners)
- combiners.insertAll(iter)
- // Update task metrics if context is not null
// TODO: Make context non optional in a future release
- Option(context).foreach { c =>
- c.taskMetrics.memoryBytesSpilled += combiners.memoryBytesSpilled
- c.taskMetrics.diskBytesSpilled += combiners.diskBytesSpilled
- }
+ val spillMetrics = Option(context).map(
+ _.taskMetrics.getOrCreateShuffleReadSpillMetrics()).getOrElse(new
WriteMetrics())
--- End diff --
If we're doing map-side combining, this should be for the shuffle write,
right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
