Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4567#issuecomment-74141527
Looks good for now. However, in the future if we want to extend dynamic
allocation to standalone mode we will have executors coming and going all the
time, in which case `coresMax` will be arbitrarily large and it might make less
sense then. @marsishandsome also what happens if executors fail multiple times
(but not enough to fail the application), do we count all those cores too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
