Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/4563#discussion_r24616222 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala --- @@ -106,12 +106,12 @@ class DefaultSource ParquetRelation.createEmpty( path, data.schema.toAttributes, - false, + true, --- End diff -- Use named parameter for allowExisting. Also, seems we will overwrite the metadata file. In the case of Append, do we still want to overwrite the metadata?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org