Github user ryan-williams commented on a diff in the pull request:
https://github.com/apache/spark/pull/4571#discussion_r24619183
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsConfig.scala
---
@@ -47,21 +47,27 @@ private[spark] class MetricsConfig(val configFile:
Option[String]) extends Loggi
setDefaultProperties(properties)
// If spark.metrics.conf is not set, try to get file in class path
- var is: InputStream = null
- try {
- is = configFile match {
- case Some(f) => new FileInputStream(f)
- case None =>
Utils.getSparkClassLoader.getResourceAsStream(METRICS_CONF)
+ (configFile match {
--- End diff --
cool, thanks, went with the first one.
incidentally I had a `Some()` where I should have had an `Option()`, which
your candidates all fix, that I think was breaking the tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
