pan3793 commented on code in PR #4651: URL: https://github.com/apache/zeppelin/pull/4651#discussion_r1327966871
########## zeppelin-web/README.md: ########## @@ -12,49 +12,49 @@ All build commands are described in [package.json](./package.json) ```sh # install required depepdencies and bower packages (only once) -$ npm install -g yarn -$ yarn install +$ npm install -g npm Review Comment: I think the change is fine. There are bunch of tools state they are better replacements of `npm`, including `yarn`, `pnpm` etc., but `npm` still be the default one shipped with NodeJS, I think only mention `npm` in guide is a better choice ########## zeppelin-web/README.md: ########## @@ -12,49 +12,49 @@ All build commands are described in [package.json](./package.json) ```sh # install required depepdencies and bower packages (only once) -$ npm install -g yarn -$ yarn install +$ npm install -g npm Review Comment: I think the change is fine. There are bunch of tools state they are better replacements of `npm`, including `yarn`, `pnpm` etc., but `npm` still is the default one shipped with NodeJS, I think only mention `npm` in guide is a better choice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
