pjfanning commented on code in PR #4719:
URL: https://github.com/apache/zeppelin/pull/4719#discussion_r1495901925


##########
pom.xml:
##########
@@ -240,12 +239,6 @@
         <version>${slf4j.version}</version>
       </dependency>
 
-      <dependency>
-        <groupId>log4j</groupId>
-        <artifactId>log4j</artifactId>

Review Comment:
   I'll have a better look over the next day or 2 to see what transitive 
dependencies could leaking log4j dependencies into zeppelin. There already 
appears to be issues (pre-existing issues unrelated to this change) where log4j 
and log4j-1.2-api are conflicting. log4j-1.2-api is a log4jv2 jar that pretends 
to be log4jv1 and you shouldn't have this on the classpath at the same time as 
you have the legacy log4j jar.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to