Reamer commented on code in PR #4691:
URL: https://github.com/apache/zeppelin/pull/4691#discussion_r1547353690


##########
rlang/pom.xml:
##########
@@ -38,7 +38,7 @@
 
         <spark.archive>spark-${spark.version}</spark.archive>
         <spark.bin.download.url>
-            
https://archive.apache.org/dist/spark/${spark.archive}/${spark.archive}-bin-without-hadoop.tgz
+            
https://archive.apache.org/dist/spark/${spark.archive}/${spark.archive}-bin-hadoop3.tgz

Review Comment:
   I think you have not understood my comment or I have overlooked a place 
where the files are used.
   In my opinion, the downloaded files are only used in the Maven execution 
maven-resources-plugin:copy-sparkr-files.
   Only a small fraction of the files are copied here. Each file under 
`/R/lib`. This folder is contained in both `spark-bin-hadoop3.tgz` and 
`spark-bin-without-hadoop.tgz`.
   
   I don't see the hadoop libraries from this download being used anywhere.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to