Reamer commented on PR #4798: URL: https://github.com/apache/zeppelin/pull/4798#issuecomment-2295800016
Hi, in my opinion `websocket-driver` should be a `devDependencies`. See the following dependency tree. ``` 08:50 $ npm ls websocket-driver zeppelin@0.0.0 /home/pdallig/git/zeppelin/zeppelin-web-angular ├─┬ @angular-devkit/build-angular@0.803.29 │ └─┬ webpack-dev-server@3.11.0 │ ├─┬ sockjs-client@1.4.0 │ │ └─┬ faye-websocket@0.11.4 │ │ └── websocket-driver@0.6.5 deduped invalid: "^0.7.4" from the root project │ └─┬ sockjs@0.3.20 │ ├─┬ faye-websocket@0.10.0 │ │ └── websocket-driver@0.6.5 deduped invalid: "^0.7.4" from the root project │ └── websocket-driver@0.6.5 deduped invalid: "^0.7.4" from the root project └── websocket-driver@0.6.5 invalid: "^0.7.4" from the root project ``` I also think that we should not interfere with angular's dependencies. I think it makes more sense to update angular itself, even if this requires more work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
