tbonelee commented on code in PR #4832:
URL: https://github.com/apache/zeppelin/pull/4832#discussion_r1760118515
##########
zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/control/control.component.html:
##########
@@ -28,22 +28,28 @@
(click)="runParagraph.emit()"
nzType="play-circle"
class="run-para"
- nzTheme="outline"></i>
+ nzTheme="outline"
+ nz-tooltip
+ nzTooltipTitle="Run paragraph"></i>
<i nz-icon
*ngIf="status=='RUNNING' || status=='PENDING'"
(click)="cancelParagraph.emit()"
class="cancel-para"
nzType="pause-circle"
- nzTheme="outline"></i>
+ nzTheme="outline"
+ nz-tooltip
+ nzTooltipTitle="Cancel paragraph"></i>
</a>
- <a (click)="toggleEditor()">
+ <a (click)="toggleEditor()" nz-tooltip nzTooltipTitle="Show/hide the code">
<i nz-icon [nzType]="editorHide ? 'fullscreen' : 'fullscreen-exit'"
nzTheme="outline"></i>
</a>
- <a (click)="toggleOutput()">
+ <a (click)="toggleOutput()" nz-tooltip nzTooltipTitle="Show/hide the output">
<i nz-icon [nzType]="tableHide ? 'book' : 'read'" nzTheme="outline"></i>
</a>
<a nz-dropdown [nzDropdownMenu]="menu" [nzTrigger]="'click'"
[nzClickHide]="false" [(nzVisible)]="dropdownVisible">
- <i nz-icon nzType="setting" nzTheme="outline"></i>
+ <span nz-tooltip nzTitle="More">
Review Comment:
Wouldn't it be better to change `nzTitle` to `nzTooltipTitle` for
consistency with the code changes above and to clarify the meaning of the
attribute?
##########
zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/control/control.component.html:
##########
@@ -28,22 +28,28 @@
(click)="runParagraph.emit()"
nzType="play-circle"
class="run-para"
- nzTheme="outline"></i>
+ nzTheme="outline"
+ nz-tooltip
+ nzTooltipTitle="Run paragraph"></i>
<i nz-icon
*ngIf="status=='RUNNING' || status=='PENDING'"
(click)="cancelParagraph.emit()"
class="cancel-para"
nzType="pause-circle"
- nzTheme="outline"></i>
+ nzTheme="outline"
+ nz-tooltip
+ nzTooltipTitle="Cancel paragraph"></i>
</a>
- <a (click)="toggleEditor()">
+ <a (click)="toggleEditor()" nz-tooltip nzTooltipTitle="Show/hide the code">
Review Comment:
It seems that this tooltip is covering the buttons located to the left of
its target, making it difficult to click those buttons once the tooltip appears.
It might be better to fix the tooltip's position, perhaps above the target.
I think you could use a property like `nzTooltipPlacement`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
