ParkGyeongTae commented on code in PR #4889:
URL: https://github.com/apache/zeppelin/pull/4889#discussion_r1829528835
##########
zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java:
##########
@@ -420,22 +427,25 @@ public boolean runParagraph(Note note,
ServiceContext context,
ServiceCallback<Paragraph> callback) throws
IOException {
-
if (note == null) {
+ LOGGER.info("Failed to run paragraph: Note is null");
return false;
}
LOGGER.info("Start to run paragraph: {} of note: {}", paragraphId,
note.getId());
if (!checkPermission(note.getId(), Permission.RUNNER,
Message.OP.RUN_PARAGRAPH, context, callback)) {
+ LOGGER.info("Permission check failed for running paragraph: {} of note:
{}", paragraphId, note.getId());
Review Comment:
@Reamer
I have completed this task. :)
##########
zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java:
##########
@@ -420,22 +427,25 @@ public boolean runParagraph(Note note,
ServiceContext context,
ServiceCallback<Paragraph> callback) throws
IOException {
-
if (note == null) {
+ LOGGER.info("Failed to run paragraph: Note is null");
return false;
}
LOGGER.info("Start to run paragraph: {} of note: {}", paragraphId,
note.getId());
if (!checkPermission(note.getId(), Permission.RUNNER,
Message.OP.RUN_PARAGRAPH, context, callback)) {
+ LOGGER.info("Permission check failed for running paragraph: {} of note:
{}", paragraphId, note.getId());
return false;
}
-
Paragraph p = note.getParagraph(paragraphId);
+
Review Comment:
@Reamer
I have completed this task. :)
##########
zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java:
##########
@@ -420,22 +427,25 @@ public boolean runParagraph(Note note,
ServiceContext context,
ServiceCallback<Paragraph> callback) throws
IOException {
-
if (note == null) {
+ LOGGER.info("Failed to run paragraph: Note is null");
return false;
}
LOGGER.info("Start to run paragraph: {} of note: {}", paragraphId,
note.getId());
if (!checkPermission(note.getId(), Permission.RUNNER,
Message.OP.RUN_PARAGRAPH, context, callback)) {
+ LOGGER.info("Permission check failed for running paragraph: {} of note:
{}", paragraphId, note.getId());
return false;
}
-
Review Comment:
@Reamer
I have completed this task. :)
##########
zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java:
##########
@@ -420,22 +427,25 @@ public boolean runParagraph(Note note,
ServiceContext context,
ServiceCallback<Paragraph> callback) throws
IOException {
-
if (note == null) {
+ LOGGER.info("Failed to run paragraph: Note is null");
return false;
}
LOGGER.info("Start to run paragraph: {} of note: {}", paragraphId,
note.getId());
if (!checkPermission(note.getId(), Permission.RUNNER,
Message.OP.RUN_PARAGRAPH, context, callback)) {
+ LOGGER.info("Permission check failed for running paragraph: {} of note:
{}", paragraphId, note.getId());
return false;
}
-
Paragraph p = note.getParagraph(paragraphId);
+
if (p == null) {
+ LOGGER.info("Paragraph with ID {} not found in note: {}", paragraphId,
note.getId());
Review Comment:
@Reamer
I have completed this task. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
