tbonelee commented on code in PR #4897:
URL: https://github.com/apache/zeppelin/pull/4897#discussion_r1829684924
##########
zeppelin-web-angular/src/app/pages/workspace/interpreter/interpreter.component.ts:
##########
@@ -46,7 +46,11 @@ export class InterpreterComponent implements OnInit,
OnDestroy {
}
filterInterpreters(value: string) {
- this.filteredInterpreterSettings = this.interpreterSettings.filter(e =>
e.name.search(value) !== -1);
+ const lowerCaseValue = value.toLowerCase();
+ this.filteredInterpreterSettings = this.interpreterSettings.filter(e =>
+ e.name.toLowerCase().includes(lowerCaseValue)
+ );
+
Review Comment:
```suggestion
this.filteredInterpreterSettings = this.interpreterSettings.filter(e =>
e.name.search(new RegExp(value, 'i')) !== -1);
```
Consider using the 'i' flag with RegExp here. This way, I think we can
support both Regex patterns and regular string searches while keeping it
case-insensitive, which would closely match the original functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
