tbonelee commented on code in PR #4969:
URL: https://github.com/apache/zeppelin/pull/4969#discussion_r2205107195


##########
bin/common.sh:
##########


Review Comment:
   In the daemon script, when the corresponding path could not be found 
automatically, it used to be coerced into an empty string. This unintentionally 
overrides the default values in `ZeppelinConfiguration`, and worse, the empty 
string can be interpreted as the current directory.
   
   To avoid this, I modified the script to set the environment variables only 
when the resolved path actually exists.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to