shmruin commented on PR #4986:
URL: https://github.com/apache/zeppelin/pull/4986#issuecomment-3105630677

   > Thanks for porting the carriage return handling form the classic UI!
   > 
   > 
   > 
   > Just a quick note. The current implementation replaces the whole line with 
only the last part after `\r`, so something like `Hello World\rDone` ends up as 
`Done`.
   > 
   > But in most REPLs or terminal-like environments, `\r` usually acts as a 
partial overwrite. So the expected output would be `Doneo World`, since only 
the beginning of the line gets overwritten and the rest stays as is.
   > 
   > 
   > 
   > Since interpreters are writing output with that behavior in mind, I think 
it might make sense to handle it that way in the new UI too. What do you think?
   
   Thanks for your review. I agree with your suggestion and will test that 
feature. But doesn't the classic UI reflect this feature? Would it be better to 
fix both classic and new UI?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to