tbonelee commented on PR #4947:
URL: https://github.com/apache/zeppelin/pull/4947#issuecomment-3113684212
The latest revision breaks the `getNotePath()` method because
`rootNotebookFolder` doesn't align with `noteFileName`.
- On Windows:
- `rootNotebookFolder` : `/C:/Users/chanlee/...`
- `noteFileName`: `/Users/chanlee/...`
- => The prefixes don't match.
IF we try to fix this by setting `rootNotebookFolder` using
`getName().getPath()` also, the `/C:` segment gets dropped, which breaks file
access.
(This effectively reverts the fix from #3615 .)
To fix the URL-encoded path issue without breaking things on Windows, we
should ensure:
- `rootNotebookFolder` includes the drive letter (e.g., `C:`) at the
beginning.
- `noteFileName` starts with the same prefix as `rootNotebookFolder`. (If
the former includes the drive letter, the latter should as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
