ParkGyeongTae commented on code in PR #4941:
URL: https://github.com/apache/zeppelin/pull/4941#discussion_r2251204906
##########
zeppelin-integration/src/test/java/org/apache/zeppelin/WebDriverManager.java:
##########
@@ -80,83 +80,44 @@ public WebDriver getWebDriver() {
}
private WebDriver constructWebDriver(int port) {
- Supplier<WebDriver> chromeDriverSupplier = () -> {
- try {
- ChromeOptions options = new ChromeOptions();
- return new ChromeDriver(options);
- } catch (Exception e) {
- LOG.error("Exception in WebDriverManager while ChromeDriver ", e);
- return null;
- }
- };
- Supplier<WebDriver> firefoxDriverSupplier = () -> {
- try {
- return getFirefoxDriver();
- } catch (Exception e) {
- LOG.error("Exception in WebDriverManager while FireFox Driver ", e);
- return null;
- }
- };
- Supplier<WebDriver> safariDriverSupplier = () -> {
- try {
- return new SafariDriver();
- } catch (Exception e) {
- LOG.error("Exception in WebDriverManager while SafariDriver ", e);
- return null;
- }
- };
+ WebDriver driver = getFirefoxDriver();
- WebDriver driver;
- switch (SystemUtils.getEnvironmentVariable("ZEPPELIN_SELENIUM_BROWSER",
"").toLowerCase(Locale.ROOT)) {
Review Comment:
I agree with you, and I've reverted the code to use this behavior
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
