kmularise commented on PR #5024: URL: https://github.com/apache/zeppelin/pull/5024#issuecomment-3193433700
> We could remove the unused `HttpParams` import and add a comment why it couldn't be used in this method. > > I believe this issue([angular/angular#11058](https://github.com/angular/angular/issues/11058)) in Angular repository is related to this PR. @tbonelee Thanks for the review. I removed the unused HttpParams import and added a comment in the login() method explaining why we manually build the payload instead of using HttpParams, referencing Angular issue [#11058](https://github.com/angular/angular/issues/11058). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
