tbonelee commented on PR #4989: URL: https://github.com/apache/zeppelin/pull/4989#issuecomment-3197777984
@jongyoul Thank you for carefully reviewing this long PR, I really appreciate it. I assume you're referring to the changes where we pass generated objects as parameters instead of reading the fields directly (e.g., `renderBefore(config, chart)`, `refreshSetting(config)`, `renderAfter(config)`). The point is that by passing the generated value, TypeScript can infer it's already defined at the call site, which removes the need for repetitive null/undefined checks. If we had relied on member fields instead, we would have needed explicit type guards to narrow them to non-null/undefined. If this wasn't the part you meant, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
