dididy commented on PR #5053: URL: https://github.com/apache/zeppelin/pull/5053#issuecomment-3234260586
Considering future-proof design also seems important, so this is probably something worth discussing further later. Thank you for the quick response. When running `npm run build:tslint-rules`, the error `TS2688: Cannot find type definition file for 'minimatch'` occurs. I determined that this is related to the internal workings of the tslint module and can be safely ignored. Therefore, I modified the `tsc` execution for building the `tslint-rules` folder to use `--types node` to bypass this error, and it now works correctly. I also discovered an issue where new lint rule did not work correctly when comments were placed above, and this has been fixed as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
