dididy commented on PR #4963: URL: https://github.com/apache/zeppelin/pull/4963#issuecomment-3261496744
87c4d19 I added the missing `isMac` variable to detect macOS. This makes the modifier key label display as `Option` on macOS and `Alt` on other platforms. 6e75ed6 In the Classic UI, auto-completion triggered by `Control + .` had to be manually activated, but in the Monaco editor used in the NewUI, it is always enabled by default. Therefore, the shortcut is unnecessary and has been removed. https://issues.apache.org/jira/browse/ZEPPELIN-6314 I’m currently looking into the E2E environment setup, and the Jira ticket is as above. It will likely use Playwright. #5044 / #5064 Once the subsequent PRs are merged, I’ll review again, and this PR can be merged afterward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
