tbonelee commented on code in PR #5089:
URL: https://github.com/apache/zeppelin/pull/5089#discussion_r2391059637
##########
.github/workflows/frontend.yml:
##########
@@ -104,28 +104,32 @@ jobs:
run:
shell: bash -l {0}
env:
- ZEPPELIN_SELENIUM_BROWSER: firefox
+ ZEPPELIN_SELENIUM_BROWSER: "edge"
steps:
- name: Checkout
uses: actions/checkout@v4
- - name: Install Firefox (non-snap) and geckodriver
- run: |
- sudo snap remove firefox || true
- sudo add-apt-repository -y ppa:mozillateam/ppa
- sudo tee -a /etc/apt/preferences.d/mozilla-firefox <<EOF
- Package: *
- Pin: release o=LP-PPA-mozillateam
- Pin-Priority: 1001
- EOF
- sudo apt-get update
- sudo apt-get install -y firefox
- GECKODRIVER_VERSION=$(curl -s
https://api.github.com/repos/mozilla/geckodriver/releases/latest | grep
tag_name | cut -d '"' -f 4)
- wget -q
https://github.com/mozilla/geckodriver/releases/download/${GECKODRIVER_VERSION}/geckodriver-${GECKODRIVER_VERSION}-linux64.tar.gz
- tar -xzf geckodriver-${GECKODRIVER_VERSION}-linux64.tar.gz
- chmod +x geckodriver
- sudo mv geckodriver /usr/local/bin/
- geckodriver --version
- firefox --version
+ - name: Tune Runner VM
+ uses: ./.github/actions/tune-runner-vm
+ - name: Set up Edge browser
+ uses: browser-actions/setup-edge@v1
+ - name: Print Edge version
+ run: msedgedriver --version
+ - name: Set up JDK 11
+ uses: actions/setup-java@v4
+ with:
+ distribution: 'temurin'
+ java-version: 11
+ - name: Cache local Maven repository
+ uses: actions/cache@v4
+ with:
+ path: |
+ ~/.m2/repository
+ !~/.m2/repository/org/apache/zeppelin/
+ ~/.spark-dist
+ ~/.cache
+ key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ ${{ runner.os }}-zeppelin-
Review Comment:
I reverted this part to align it with other jobs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
