tbonelee commented on code in PR #5092:
URL: https://github.com/apache/zeppelin/pull/5092#discussion_r2402483405
##########
zeppelin-web-angular/src/app/share/note-import/note-import.component.ts:
##########
@@ -92,7 +92,7 @@ export class NoteImportComponent extends
MessageListenersManager implements OnIn
// @ts-ignore
result.name = this.noteImportName;
}
- this.messageService.importNote(result as SendNote);
+ this.messageService.importNote(result as ImportNote['note']);
Review Comment:
Are you suggesting we change the `data` argument type to
`ImportNote['note']`?
Since `data` comes from outside the Zeppelin application(user-provided file
or HTTP request) and the method already validates its shape(though somewhat
superficially), I believe keeping it as `unknown` is more appropriate. What do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
