On 07.10.2025 15:48, Michael Richardson wrote:
Eliot Lear<[email protected]> wrote: >> The way to deal with this is GitHub suggestions.> I think I said this before, but in my experience, this works well for small > PRs, and lousy for big PRs with lots of suggestions. Does "suggestion" here refer to the github thing, or the things the RPC proposes?
Github ```suggestion
1. This works well when the PR has a small number of changes.
-or-
2. This works well when the PR has a small number of author responses in the
form of github suggestions.
Suggestions can be committed directly into a PR, and that works for simple replacements. So long as the PRs are bite-sized, I think this should work. But if they're lengthy, and if there are multiple authors, or worse, others, making suggestions, it can be messy. We had this problem with one or two PRs with modpod, where just had to close them and create new ones (we were tripping over accepting suggestions and other commits).
Keeping it simple and small likely avoids that. Eliot
OpenPGP_0x87B66B46D9D27A33.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ rfc-interest mailing list -- [email protected] To unsubscribe send an email to [email protected]
