On Sun, 2008-07-27 at 12:00 +0000, Jonathan Matthew
<[EMAIL PROTECTED]> wrote:

> Please attach patches to bugs in bugzilla.gnome.org; otherwise, they
> tend to be forgotten.

Understood. Posted to...
http://bugzilla.gnome.org/show_bug.cgi?id=545039

> We don't use hungarian notation..

Fixed. Old habits die hard.

> .. or c++-style comments.

Fixed. Thanks.

> Most of the rest of the code from here on was more or less identical
> to
> that in rhythmdb_compute_status_normal.  Rather than adding another
> mostly-identical copy, it should be extracted out into a utility
> function somewhere.

Sort of. There are some subtle differences in the generated string since
it needs to be slightly more compact, given where it is displayed. It
also needed some different hints for gettext. Nevertheless, I figured
the code may be re-used again so I put it in its own routine as you
recommended.

-- 
Kip Warner -- Software Engineer
OpenPGP encrypted/signed mail preferred
http://www.thevertigo.com

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
rhythmbox-devel mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/rhythmbox-devel

Reply via email to