On Tue, 2011-05-03 at 07:15 -0400, Stephen Huenneke wrote: > Sorry, I'm not much of a c developer, I was just trying to be helpful > and give you folks more info than just a complaint. Does the bug, > ignoring my bad patch, seem legitimate?
File a bug please, yes. > On May 3, 2011 7:11 AM, "Bastien Nocera" <[email protected]> wrote: > > On Mon, 2011-05-02 at 16:58 -0400, Stephen Huenneke wrote: > >> > >> diff --git a/plugins/daap/rb-daap-plugin.c > >> b/plugins/daap/rb-daap-plugin.c > >> index 20cc539..fc72ac0 100644 > >> --- a/plugins/daap/rb-daap-plugin.c > >> +++ b/plugins/daap/rb-daap-plugin.c > >> @@ -646,6 +646,7 @@ new_daap_share_location_added_cb (RBURIDialog > >> *dialog, > >> host = g_strdup (location); > >> p = strrchr (host, ':'); > >> if (p != NULL) { > >> + host = g_strndup (location, p); > > > > > > That should probably be "p - location", instead of "p", and you're > > leaking the host as well. > > > >> port = strtoul (p+1, NULL, 10); > >> *p = '\0'; > >> } > >> > >> > > > _______________________________________________ rhythmbox-devel mailing list [email protected] http://mail.gnome.org/mailman/listinfo/rhythmbox-devel
