I've pulled in your changes. Thank you for the revised pull request. Thanks, Dan
Daniel Reverri Developer Advocate Basho Technologies, Inc. [email protected] On Mon, Jan 10, 2011 at 2:48 PM, Anthony Molinaro < [email protected]> wrote: > Hi Dan, > > I just managed to get a proper pull request sent to you for just the > documentation changes. Hopefully it works for you. > > I also hope you guys consider joining back with the community of developers > working on erlang_protobuffs so riak can be used along side other protobuff > based systems. > > -Anthony > > On Fri, Jan 07, 2011 at 03:57:45PM -0800, Anthony Molinaro wrote: > > > > On Fri, Jan 07, 2011 at 03:38:45PM -0800, Dan Reverri wrote: > > > Hi Anthony, > > > > > > Would you mind sending a pull request for the documentation updates > without > > > the protobuffs changes? > > > > I was trying to figure out how to do that, but it seems to be alluding > me, > > still a bit of a noob with git. I'll try to figure it out and do that. > > > > > Regarding the protobuffs changes, it would be best to apply the changes > to a > > > fork of the basho/erlang_protobuffs repository and send a pull request. > > > > Well the whole point of this was that basho/erlang_protobuffs is an > ancient > > fork that went to bitbucket, then when it came back was it's own separate > > thing from the mainline (everything downstream of Nick Gerakine's > original > > implementation). I use the mainline for other projects which I also want > > to use riak-erlang-client with. So the fact that it had it's own > > implementation caused some conflicts. Thus I did the work to hand merge > > the changes from the basho tree into the mainline (the seemed to just be > > some minor iolist functions). The mainline has had some very nice recent > > features, the handrolled parser was replaced with a leex/yecc one, and > > support has been added for many protobuff features (like booleans, enums, > > packed format, etc). So anyway, maybe there's a way to relink the > > basho/erlang_protobuffs into the mainline? (again I'm a bit of a git noob > > so no idea if its possible to do that). > > > > > Regarding the buckets, they should be specified as binaries. I'll fix > that > > > now. > > > > Cool, I'll look for it. > > > > -Anthony > > > > -- > > ------------------------------------------------------------------------ > > Anthony Molinaro <[email protected]> > > > > _______________________________________________ > > riak-users mailing list > > [email protected] > > http://lists.basho.com/mailman/listinfo/riak-users_lists.basho.com > > -- > ------------------------------------------------------------------------ > Anthony Molinaro <[email protected]> >
_______________________________________________ riak-users mailing list [email protected] http://lists.basho.com/mailman/listinfo/riak-users_lists.basho.com
