[
https://issues.jboss.org/browse/RF-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12809354#comment-12809354
]
Juraj Húska edited comment on RF-12802 at 10/14/13 4:05 AM:
------------------------------------------------------------
Couple of additional refactorings, we have discussed offline:
* Create interface for method {{advance()}} -
{code}
AdvancedInteractions<T> {
T advanced();
}
{code}
We can document the method more easily - the fragment will implement that
interface
* provide a way to set JS strategy in {{arquillian.xml}} - e.g.
{code:xml}
<extension name="richfacesPageFragments"><property
name="controlStrategy">interactive</property>
{code}
See ARQGRA-325 comments as well.
* waiting API - put {{withTimeout}} right to the wrapper, so the public API
methods do not have call for the actual timeout value
* rename the parameter for setting of the timeout from _timeout_ to something
which shows in what time unit it is - e.g. miliseconds
* move fields which hold timeout value to the {{AdvancedInteraction}} classes
* use miliseconds in waiting API instead of seconds as we found them to be more
used accros tests
* review exception throwing - throw them where it is necessary, make the method
no operation where it is not necessary
* make an attribute from
[this|https://github.com/richfaces/richfaces-qa/blob/master/page-fragments/src/main/java/org/richfaces/tests/page/fragments/impl/inplaceSelect/RichFacesInplaceSelect.java#L218-L224].
* make a pull request with moved repository
* write Javadoc
was (Author: jhuska):
Couple of additional refactorings, we have discussed offline:
* Create interface for method {{advance()}} -
{code}
AdvancedInteractions<T> {
T advanced();
}
{code}
We can document the method more easily - the fragment will implement that
interface
* provide a way to set JS strategy in {{arquillian.xml}} - e.g.
{code:xml}
<extension name="richfacesPageFragments"><property
name="controlStrategy">interactive</property>
{code}
See ARQGRA-325 comments as well.
* waiting API - put {{withTimeout}} right to the wrapper, so the public API
methods do not have call for the actual timeout value
* rename the parameter for setting of the timeout from _timeout_ to something
which shows in what time unit it is - e.g. miliseconds
* move fields which hold timeout value to the {{AdvancedInteraction}} classes
* use miliseconds in waiting API instead of seconds as we found them to be more
used accros tests
* review exception throwing - throw them where it is necessary, make the method
no operation where it is not necessary
* make an attribute from
[this|https://github.com/richfaces/richfaces-qa/blob/master/page-fragments/src/main/java/org/richfaces/tests/page/fragments/impl/inplaceSelect/RichFacesInplaceSelect.java#L218-L224].
* make a pull request with moved repository
> Move page fragments from repository qa to richfaces5
> ----------------------------------------------------
>
> Key: RF-12802
> URL: https://issues.jboss.org/browse/RF-12802
> Project: RichFaces
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: build/distribution
> Affects Versions: 5.0.0.Alpha1
> Reporter: Pavol Pitonak
> Assignee: Juraj Húska
> Fix For: 5.0.0.Alpha2
>
> Original Estimate: 1 week
> Remaining Estimate: 1 week
>
> As discussed on community meeting on Feb 12, we should move page fragments
> for RichFaces components to richfaces5 repository so that they are
> distributed with framework.
> We should find out how to prepare them so that they are easy to use for
> community members. RichFaces QE/dev need to test internals of components,
> community members will probably test only high-level functionality of
> components. One possible solution would be to create package "internal" in
> which there would be page fragments extending those from "public" package. QE
> team would then use "internal" implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
richfaces-issues mailing list
[email protected]
https://lists.jboss.org/mailman/listinfo/richfaces-issues
