[ 
https://issues.jboss.org/browse/RF-13533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Leathem updated RF-13533:
-------------------------------

    Description: 
jQuery usage by RichFaces was corrected to work properly with jQuery  
noConclift in RF 4.5/5.0 with the resolution of RF-12936.  This issue addresses 
backporting those changes into the 4.3.x branch.

----

Summary was: rich:fileUpload doesn't work with jQuery in noConflict mode

Hi all,

For compatibility with other components used within our application, we 
manually include a copy of jQuery in noConflict mode within our page header 
template rather than let RichFaces include its own.

This works fine for us, except when using the <rich:fileUpload> component which 
throws a Javascript error. Casual inspection of the source shows that this is 
due to a typing error where $ is used directly within fileupload.js rather than 
using the passed-in parameter. The following diff fixes the error for us:

{code}
$ diff -u fileupload.js.orig fileupload.js
--- fileupload.js.orig  2014-02-04 15:07:05.000000000 +0000
+++ fileupload.js       2014-02-04 15:08:32.000000000 +0000
@@ -98,7 +98,7 @@
 
     richfaces.BaseComponent.extend(richfaces.ui.FileUpload);
 
-    $.extend(richfaces.ui.FileUpload.prototype, (function () {
+    jQuery.extend(richfaces.ui.FileUpload.prototype, (function () {
 
         return {
             name: "FileUpload",
{code}

The bug was found during the development of our main application under RF 
4.2.3.Final, however a quick test with RF 4.3.5 JARs shows that the bug is 
still present.


Many thanks,

Mark.


  was:
Hi all,

For compatibility with other components used within our application, we 
manually include a copy of jQuery in noConflict mode within our page header 
template rather than let RichFaces include its own.

This works fine for us, except when using the <rich:fileUpload> component which 
throws a Javascript error. Casual inspection of the source shows that this is 
due to a typing error where $ is used directly within fileupload.js rather than 
using the passed-in parameter. The following diff fixes the error for us:

{code}
$ diff -u fileupload.js.orig fileupload.js
--- fileupload.js.orig  2014-02-04 15:07:05.000000000 +0000
+++ fileupload.js       2014-02-04 15:08:32.000000000 +0000
@@ -98,7 +98,7 @@
 
     richfaces.BaseComponent.extend(richfaces.ui.FileUpload);
 
-    $.extend(richfaces.ui.FileUpload.prototype, (function () {
+    jQuery.extend(richfaces.ui.FileUpload.prototype, (function () {
 
         return {
             name: "FileUpload",
{code}

The bug was found during the development of our main application under RF 
4.2.3.Final, however a quick test with RF 4.3.5 JARs shows that the bug is 
still present.


Many thanks,

Mark.



    
> Port the jQuery noConlfict fixes back to RF 4.3.x
> -------------------------------------------------
>
>                 Key: RF-13533
>                 URL: https://issues.jboss.org/browse/RF-13533
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component
>    Affects Versions: 4.2.3.Final, 4.3.5
>         Environment: Tomcat 7, RichFaces 4.2.3.Final, Debian Wheezy x86_64
>            Reporter: Mark Cave-Ayland
>
> jQuery usage by RichFaces was corrected to work properly with jQuery  
> noConclift in RF 4.5/5.0 with the resolution of RF-12936.  This issue 
> addresses backporting those changes into the 4.3.x branch.
> ----
> Summary was: rich:fileUpload doesn't work with jQuery in noConflict mode
> Hi all,
> For compatibility with other components used within our application, we 
> manually include a copy of jQuery in noConflict mode within our page header 
> template rather than let RichFaces include its own.
> This works fine for us, except when using the <rich:fileUpload> component 
> which throws a Javascript error. Casual inspection of the source shows that 
> this is due to a typing error where $ is used directly within fileupload.js 
> rather than using the passed-in parameter. The following diff fixes the error 
> for us:
> {code}
> $ diff -u fileupload.js.orig fileupload.js
> --- fileupload.js.orig  2014-02-04 15:07:05.000000000 +0000
> +++ fileupload.js       2014-02-04 15:08:32.000000000 +0000
> @@ -98,7 +98,7 @@
>  
>      richfaces.BaseComponent.extend(richfaces.ui.FileUpload);
>  
> -    $.extend(richfaces.ui.FileUpload.prototype, (function () {
> +    jQuery.extend(richfaces.ui.FileUpload.prototype, (function () {
>  
>          return {
>              name: "FileUpload",
> {code}
> The bug was found during the development of our main application under RF 
> 4.2.3.Final, however a quick test with RF 4.3.5 JARs shows that the bug is 
> still present.
> Many thanks,
> Mark.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
richfaces-issues mailing list
[email protected]
https://lists.jboss.org/mailman/listinfo/richfaces-issues

Reply via email to