[
https://issues.jboss.org/browse/RF-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991748#comment-12991748
]
Pavol Pitonak commented on RF-13749:
------------------------------------
I think that it can be merged.
> Upgrade HtmlUnit to 2.15
> ------------------------
>
> Key: RF-13749
> URL: https://issues.jboss.org/browse/RF-13749
> Project: RichFaces
> Issue Type: Component Upgrade
> Security Level: Public(Everyone can see)
> Components: tests - functional , tests - unit
> Affects Versions: 4.5.0.Alpha3
> Reporter: Pavol Pitonak
> Fix For: 4.5.0.Beta1
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> I'd like to upgrade our testing dependencies (Arquillian Core, Arquillian
> Drone, Selenium) but HtmlUnit needs to be upgraded from 2.12 to 2.15 first
> because it's a transitive dependency of Selenium.
> I upgraded it on a feature branch \[1]. However, there were some problems
> after upgrade:
> # HtmlUnit's API changed slightly, thise are easy fixes.
> # DummyQueueTest is failing after HtmlUnit upgrade, it seems that it doesn't
> test anything (there are no asserts, only prints to console) so I removed it
> \[2].
> # One test in DataGridRendererTest was failing, I refactored it.
> # Two tests in AutocompleteRendererTest were failing, I removed them because
> it doesn't test layout=table and these tests are already in Metamer. We might
> consider migrating this particular test from Metamer to the framework (as an
> Arquillian test). IMHO it's not worth fixing HtmlUnit test. \[3]
> \[1] https://github.com/richfaces/richfaces/tree/htmlunit_upgrade
> \[2]
> https://github.com/richfaces/richfaces/commit/ebb5df8a5dfeaacc47cf4187e3a6c26bdc7d5299
> \[3]
> https://github.com/richfaces/richfaces/commit/2a0a0ec1260ef83df2b83ba64f1d5268a8c1c710
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
_______________________________________________
richfaces-issues mailing list
[email protected]
https://lists.jboss.org/mailman/listinfo/richfaces-issues
