Hi Peter,
Peter Jones wrote:
On May 31, 2008, at 6:32 AM, Mark Brouwer wrote:
Mark Brouwer wrote:
All,
Attached you will find a patch for RIVER-147 and RIVER-265. Note that
RIVER-147 represent a new protected method on a class in the net.jini
namespace. To me this a public API change in the net.jini namespace so
please all have a good look at it and tell what you think of it.
The enhancements represent the minimal specification of what is referred
to in RIVER-147, but the enhancements represent all that I needed to
support codebase evolution for Seven.
RIVER-265 represents an internal change that is a direct consequence of
the functionality provided by RIVER-147.
Did anyone have had a look at this change, I don't want to commit this
given the fact it is a change in the net.jini API which is rather hard
to remove if it turns out it ain't that smart after all.
Yes, I finally got a chance to start looking at this yesterday, and I
hope to write up a few comments in the next day or so (I don't have much
time at the this immediate moment, though).
One preliminary question: could you explain the thinking that led you to
making the codebase parameter to the new protected method be a String
instead of a URL[] (which will already have been computed at the
corresponding points in the implementation, as effectively required by
the spec)? I'm not asserting that this is the wrong choice, just
wondering what your motivation was, to help me think about it. Thanks.
I think the best thing to do is to read these thread from almost a year
ago as a refresher
http://mail-archives.apache.org/mod_mbox/incubator-river-dev/200706.mbox/[EMAIL
PROTECTED]
. I hope this makes clear why I came up with the API as it is [1]. I
think I fail to understand your remark "as effectively required by the
spec", so could you give me an extra hint here as to what you are referring.
[1] from that thread I can understand people fail to see why the
signature doesn't have both the codebase string and URL array but I
decided in that year that I didn't like that.
--
Mark
