Jonathan Costers (JIRA) wrote:
[ https://issues.apache.org/jira/browse/RIVER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693546#action_12693546 ]
Jonathan Costers edited comment on RIVER-272 at 3/29/09 5:50 PM:
-----------------------------------------------------------------
Thanks for the code! I'm testing it right now.
If all seems to work, I'll provide a patch for build.xml and
integrationtest.xml.
EDIT:
I have successfully built and run ClassDepend on a number of JAR targets in the QA suite build. It seems to calculate the same dependencies as ClassDep.
However, the command line options are not the same as for ClassDep, so integrating it into the build would require quite some work. Not impossible though.
I was thinking of implementing a ProxyClassDep to convert the command
line input from ClassDepLoader to ClassDepend or fallback to ClassDep
(if its in the classpath) when ClassDepend doesn't implement the
functionality.
Also, how do we best handle the dependency on ASM?
Perhaps the library be located at trunk/lib/asm-2.2.3.jar and
trunk/lib/asm-commons-2.2.3.jar and be downloaded and updated via svn.
The build scripts need to change the namespace with jarjar to, for
example, org.river.lib.asm.* to get it out of the way for client code.
Best
Jonathan
was (Author: jcosters):
Thanks for the code! I'm testing it right now.
If all seems to work, I'll provide a patch for build.xml and
integrationtest.xml too.
Best
Jonathan
ClassDep.java relies on Sun specific Internal JDK API
------------------------------------------------------
Key: RIVER-272
URL: https://issues.apache.org/jira/browse/RIVER-272
Project: River
Issue Type: Improvement
Components: com_sun_jini_tool
Affects Versions: jtsk_2.1
Environment: Windows XP, JDK 1.4 - JDK 1.6, Eclipse 3.3 IDE
Reporter: Hakan Kocakulak
Attachments: classdepend.zip, classdepend_backport.tgz
ClassDep.java relies on Sun specific Internal JDK API
import sun.tools.java.BinaryClass;
import sun.tools.java.ClassDeclaration; import
sun.tools.java.ClassFile; import sun.tools.java.ClassNotFound; import
sun.tools.java.ClassPath; import sun.tools.java.Constants; import
sun.tools.java.Environment; import sun.tools.java.Identifier; import
sun.tools.java.MemberDefinition; import sun.tools.java.Package; import
sun.tools.java.Type;
while building from eclipse IDE, IDE do not add these Classes to classpath and
can not build project.
