Hi,
On Fri, Apr 17, 2009 at 12:32 PM, <[email protected]> wrote:
> Log:
> Changes for RIVER-272.
When submitting code written by others, it's a good idea to mention
the author in the commit message. I would personally have used a
commit message like:
RIVER-272: ClassDep.java relies on Sun specific Internal JDK API
Added com.sun.jini.tool.classdepend classes contributed by Peter Firmstone.
> Added:
> incubator/river/jtsk/skunk/jcosters/src/com/sun/jini/tool/classdepend/
Again, why not commit this in trunk?
> ==============================================================================
> ---
> incubator/river/jtsk/skunk/jcosters/src/com/sun/jini/tool/classdepend/AbstractVisitor.java
> (added)
> +++
> incubator/river/jtsk/skunk/jcosters/src/com/sun/jini/tool/classdepend/AbstractVisitor.java
> Fri Apr 17 10:32:02 2009
> @@ -0,0 +1,42 @@
> +package com.sun.jini.tool.classdepend;
> +[...]
All source files should start with the standard Apache license header
from http://www.apache.org/legal/src-headers.html:
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
BR,
Jukka Zitting
