Jonathan Costers wrote:
Thank you, I will review and include your patch in the trunk as soon as I
can.
To my knowledge, there are no test cases defined anywhere for the tools
(classdep, preferredlistgen etc.), also not in the QA suite.
So this may be an opportunity to introduce JUnit? Like Jukka mentioned
before, it should fairly straight forward to write JUnit tests for ClassDep
for instance.
Good idea, can someone create a "unit-test" directory in the main
trunk? Should I raise an issue on Jira? A bit off topic, but related,
I noticed there two directory trees, one called integrationtests and the
other called qa, if we create a "unit-test" directory, it would be nice
to have an "integration-test" directory for clarity.
Nice work converting all the integration tests to ant, heaps of effort,
long hours, much appreciated.
Cheers,
Peter.
Thanks and best regards
Jonathan
2009/4/21 Peter Firmstone (JIRA) <[email protected]>
[
https://issues.apache.org/jira/browse/RIVER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701077#action_12701077]
Peter Firmstone commented on RIVER-272:
---------------------------------------
The latest patch is sufficient to resolve this issue for an AR2 release.
I suggest creating a separate issue for the -outer functionality, as this
behaviour is now enabled by default. I couldn't find a test case where the
Containing class wasn't present in the output with the old ClassDep tool.
It should also resolve River-163, does anyone have any test cases for
River-163 we can try out?
Note the classdepend API is more powerful than ClassDep, feel free to check
it out.
After AR2 I'd like to add method and field dependency analysis to assist
River API analysis and development, however it should be left for an
improvement issue.
Cheers,
Peter.
ClassDep.java relies on Sun specific Internal JDK API
------------------------------------------------------
Key: RIVER-272
URL: https://issues.apache.org/jira/browse/RIVER-272
Project: River
Issue Type: Improvement
Components: com_sun_jini_tool
Affects Versions: jtsk_2.1
Environment: Windows XP, JDK 1.4 - JDK 1.6, Eclipse 3.3 IDE
Reporter: Hakan Kocakulak
Attachments: ClassDep-a4.patch, ClassDep-a5.patch,
ClassDep-a6.patch, classdepend.zip, classdepend_backport.tgz,
ClassDepReplacement.tgz, ClassDepReplacement_alpha-2.tgz,
ClassDepReplacement_alpha-3.tgz, ClassDepReplacement_alpha-4.tgz
ClassDep.java relies on Sun specific Internal JDK API
import sun.tools.java.BinaryClass;
import sun.tools.java.ClassDeclaration; import
sun.tools.java.ClassFile; import sun.tools.java.ClassNotFound; import
sun.tools.java.ClassPath; import sun.tools.java.Constants; import
sun.tools.java.Environment; import sun.tools.java.Identifier; import
sun.tools.java.MemberDefinition; import sun.tools.java.Package; import
sun.tools.java.Type;
while building from eclipse IDE, IDE do not add these Classes to
classpath and can not build project.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
