On 7/18/2010 12:18 PM, Peter Firmstone wrote:
Patricia Shanahan wrote:
...
To me, this all seems as though the if-new test is more closely
coupled to RegisterImpl than to TaskManager.
It might be better to change RegisterImpl to check if it has been run
already with a volatile boolean, and if so return immediately.
Well, it does need to check for the fields that make AddressTask
instances equal, a host and a port. However, RegisterImpl has its own
synchronization design, and it should be fitted into that.
Patricia
