> Here is small patch which replaces questionable (ugly ?)
> Rivet_IsRivetFile function,

Definitely ugly, no question about it.

> with cleaner  equivalent.
> It compiles fine for me.
> Please review and test.

Looks good to me!

Massimo writes:
> is there any tricky reason
> (that we may be overlooking) for adopting the basic method
> of scanning the whole file name in order to extract the
> file type?

Nope.  The Apache2 code is pretty messy.  The 1.3 code does pretty
much everything correctly, and should be used as an example.

-- 
David N. Welton
http://www.welton.it/davidw/

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to