Since we are getting serious about releasing, I reviewed the test suite.
I knew a few tests failed when I tried it first. Quite luckily all of them
(except for one) needed just the locale to be set as recommended. Only
upload.test failed because the command 'upload <uploadname> size' returned a
slightly wrong file size.
The patch that fixes the problem is very simple and if no objection is raised
i will commit soon
-- Massimo
Index: upload.test
===================================================================
--- upload.test (revision 935412)
+++ upload.test (working copy)
@@ -9,7 +9,7 @@
set data [read $fl]
close $fl
- set outputData "--$bound\r\nContent-Disposition: form-data;
name=\"uploadtest\"; filename=\"AngeloFish.jpg\"\r\n\r\n$data\n${bound}--"
+ set outputData "--$bound\r\nContent-Disposition: form-data;
name=\"uploadtest\"; filename=\"AngeloFish.jpg\"\r\n\r\n$data\n--${bound}--"
set page [::http::geturl "${urlbase}$testfilename1" \
-type "multipart/form-data; boundary=$bound" -query
$outputData]
@@ -17,7 +17,7 @@
set ret [string trim [::http::data $page]]
::http::cleanup $page
set ret
-} {uploadtest 1 42747 AngeloFish.jpg}
+} {uploadtest 1 42747 -- AngeloFish.jpg}
set testfilename1 uploadsave.rvt
@@ -29,7 +29,7 @@
set data [read $fl]
close $fl
- set outputData "--$bound\r\nContent-Disposition: form-data;
name=\"uploadtest\"; filename=\"AngeloFish.jpg\"\r\n\r\n$data\n${bound}--"
+ set outputData "--$bound\r\nContent-Disposition: form-data;
name=\"uploadtest\"; filename=\"AngeloFish.jpg\"\r\n\r\n$data\n--${bound}--"
set page [::http::geturl "${urlbase}$testfilename1" \
-type "multipart/form-data; boundary=$bound" -query
$outputData]
Index: upload.rvt
===================================================================
--- upload.rvt (revision 935412)
+++ upload.rvt (working copy)
@@ -1,5 +1,2 @@
-<?
+<? puts "[upload names] [upload exists uploadtest] [upload size uploadtest]
-[upload type uploadtest]- [upload filename uploadtest]" ?>
-puts "[upload names] [upload exists uploadtest] [upload size uploadtest]
[upload type uploadtest] [upload filename uploadtest]"
-
-?>
--
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
