Even though a vote has been held on the pmc list, with a general
consensus to release Rivet 2.0.1 I think these two bugs should make it
into the new release, as their impact is such that Session package
wouldn't work for a Postgres installation. I will ask the pmc list
members to swiftly express a new vote and then release this time. These
are the bugs
1) the rivet_session_cache were created with key_ and package_ columns
still named 'key' and 'package'. These columns had been renamed because
Mysql and Oracle (iirc) consider these as keywords,therefore they are
reserved words. session-create.sql needed to be changed accordingly
2) Suprisingly also rivet/packages/dio/dio_Postgresql.tcl had a typo in
a variable name causing method 'store' to fail
Index: rivet/packages/session/session-create.sql
===================================================================
--- rivet/packages/session/session-create.sql (revision 961366)
+++ rivet/packages/session/session-create.sql (working copy)
@@ -16,8 +16,8 @@
create table rivet_session_cache(
session_id varchar REFERENCES rivet_session(session_id) ON
DELETE CASCADE,
- package varchar,
- key varchar,
+ package_ varchar,
+ key_ varchar,
data varchar,
UNIQUE( session_id, package, key )
Index: rivet/packages/dio/dio_Postgresql.tcl
===================================================================
--- rivet/packages/dio/dio_Postgresql.tcl (revision 961366)
+++ rivet/packages/dio/dio_Postgresql.tcl (working copy)
@@ -138,7 +138,7 @@
# did, put that in in place of numrows, hiding a postgresql
# idiosyncracy from DIO
if {$numrows == 0} {
- set cmdrows [pg_result $resultId -cmdTuples]
+ set cmdrows [pg_result $resultid -cmdTuples]
if {$cmdrows != ""} {
set numrows $cmdrows
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
