On Sun, Oct 19, 2008, [EMAIL PROTECTED] wrote: > Date: 2008-10-19 16:11:01 +0200 (Sun, 19 Oct 2008) > New Revision: 18836 > > Log Message: > Add e200v2 and m200v2 targets. Move the telechips lcd-ssd1815.c (currently > used by Logik DAX and m200v1 ports) driver up in the target tree and share > with the m200v2 - as2525 parts contributed by Rafael Carre. Includes the > start (but is still very incomplete) of an LCD driver for the e200v2. m200v2 > is not yet fully supported by mkamsboot - that will come soon. Also some > minor cleanups for the Clip.
> Modified: trunk/firmware/export/config-clip.h > =================================================================== ... > +#define MI4_FORMAT > +#define BOOTFILE_EXT "sansa" > +#define BOOTFILE "rockbox." BOOTFILE_EXT > +#define BOOTDIR "/.rockbox" Isn't that needed only for PP targets ? > Copied: trunk/firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c (from rev > 18822, trunk/firmware/target/coldfire/iriver/h300/lcd-h300.c) > =================================================================== .. > +{ > + ams3525_dbop_init(); > + > + /* Init GPIOs the same as the OF */ > + > + GPIOA_DIR |= (1<<5); > + GPIOA_PIN(5) = 0; > + > + GPIOA_PIN(3) = (1<<3); > + > + GPIOA_DIR |= (3<<3); > + > + GPIOA_PIN(3) = (1<<3); > + > + GPIOA_PIN(4) = 0; //c80b0040 := 0; > + > + GPIOA_DIR |= (1<<7); > + GPIOA_PIN(7) = 0; You can group the directions (GPIOA_DIR |= ((1<<7)|(1<<5)|(1<<4)|(1<<3)) ) it's clearer to read > + CCU_IO &= ~(1<<2); > + CCU_IO &= ~(1<<3); same here, you should change the 2 bits at the same time (they define if xpd is gpio/sd interface) > + GPIOD_DIR |= (1<<7); > + > +#if 0 > + /* TODO: This code is conditional on a variable in the OF init, we need to > + work out what it means */ > + > + GPIOD_PIN(7) = (1<<7); > + GPIOD_DIR |= (1<<7); > +#endif This one is the button led, I think you can safely ignore it. > Copied: trunk/firmware/target/arm/lcd-ssd1815.c (from rev 18822, > trunk/firmware/target/arm/tcc77x/lcd-ssd1815.c) > =================================================================== .. > +#if CONFIG_CPU == AS3525 > +#include "as3525.h" > + > +void lcd_write_command(int byte) > +{ > + DBOP_TIMPOL_23 = 0x6006E; Isn't it better to match the model rather than the SoC ? (#ifdef SANSA_M200V2) -- Rafaël Carré