(2010/12/07 7:28), mai...@svn.rockbox.org wrote:
> Date: 2010-12-06 23:28:14 +0100 (Mon, 06 Dec 2010)
> New Revision: 28753
>
> Log Message:
> Fix configure and lib path
>
> Modified:
>     trunk/firmware/export/rbpaths.h
>     trunk/tools/configure
>
> Modified: trunk/tools/configure
> ===================================================================
> --- trunk/tools/configure  2010-12-06 22:26:31 UTC (rev 28752)
> +++ trunk/tools/configure  2010-12-06 22:28:14 UTC (rev 28753)
> @@ -3144,14 +3145,7 @@
>     defendian="ROCKBOX_LITTLE_ENDIAN"
>   fi
>
> -if [ "$ARG_RBDIR" ]; then
> -  if [ "$need_full_path" != "yes" ]; then
> -    if [ -z `echo $ARG_RBDIR | grep '^/'` ]; then
> -        rbdir="/"$ARG_RBDIR
> -    else
> -        rbdir=$ARG_RBDIR
> -    fi
> -  fi
> +if [ "$ARG_RBDIR" != "" ]; then
>     echo "Using alternate rockbox dir: ${rbdir}"
>   fi
>

Hi, kugel.

Could you explain why you removed these lines?
It only seems to break --rbdir option for native builds.
I use this option, and it is inconvenient to me that it doesn't work.
Also, "WARNING: PREFIX not supported on Android. You can however use --rbdir" near line 118 in configure is false..

> @@ -3401,8 +3398,9 @@
>   export encod...@encoder@
>   export use_e...@use_elf@
>   export rbd...@rbdir@
> -export rockbox_binary_pa...@binpath@
> +export rockbox_share_pa...@sharepath@
>   export rockbox_library_pa...@libpath@
> +export rockbox_library_pa...@libpath@
>   export sdlconf...@sdlconfig@
>
>   configure_optio...@cmdline@
>
btw, this chagnge looks strange to me.
it adds second ROCKBOX_LIBRARY_PATH and removesROCKBOX_BINARY_PATH.

best regards,
teru

Reply via email to